From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 42B4DA06B1 for ; Tue, 13 Jun 2023 14:06:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 22E012F89D for ; Tue, 13 Jun 2023 14:06:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 13 Jun 2023 14:06:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6740744EDD for ; Tue, 13 Jun 2023 14:06:37 +0200 (CEST) From: Leo Nunner To: pve-devel@lists.proxmox.com Date: Tue, 13 Jun 2023 14:06:31 +0200 Message-Id: <20230613120634.155490-1-l.nunner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.098 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v2 firewall manager] firewall: introduce scoping for ipsets/aliases X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jun 2023 12:06:38 -0000 Changes since v1: - fix adding entries to IPSets on the cluster level - code style improvements - adapt to the scoping change with 'guest/' The GUI now just shows the scope "Datacenter/Guest", and returns the concatenated value ('$scope/$value') automatically. pve-firewall: Leo Nunner (2): api: fix scoping for ipset endpoint fix #4556: api: return scoped IPSets and aliases src/PVE/API2/Firewall/Cluster.pm | 34 +++-------------------- src/PVE/API2/Firewall/IPSet.pm | 2 ++ src/PVE/API2/Firewall/VM.pm | 46 +++++++------------------------- src/PVE/Firewall/Helpers.pm | 39 +++++++++++++++++++++++++++ 4 files changed, 54 insertions(+), 67 deletions(-) pve-manager: Leo Nunner (1): firewall: add scope field to IPRefSelector www/manager6/form/IPRefSelector.js | 35 +++++++++++++++++++++++++++--- 1 file changed, 32 insertions(+), 3 deletions(-) -- 2.30.2