From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 98D08A0226 for ; Mon, 12 Jun 2023 14:43:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 826BB235F9 for ; Mon, 12 Jun 2023 14:43:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 12 Jun 2023 14:43:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8090C43AE3 for ; Mon, 12 Jun 2023 14:43:57 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 12 Jun 2023 14:43:55 +0200 Message-Id: <20230612124356.3455888-3-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230612124356.3455888-1-d.csapak@proxmox.com> References: <20230612124356.3455888-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager 2/3] ui: realm sync: change enabled column rendering X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jun 2023 12:43:58 -0000 to make it consistent with the repositories ui, since having a checkbox that is not clickable is confusing Signed-off-by: Dominik Csapak --- www/manager6/dc/RealmSyncJob.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/www/manager6/dc/RealmSyncJob.js b/www/manager6/dc/RealmSyncJob.js index 8a1fb2b2..74942829 100644 --- a/www/manager6/dc/RealmSyncJob.js +++ b/www/manager6/dc/RealmSyncJob.js @@ -49,16 +49,19 @@ Ext.define('PVE.dc.RealmSyncJobView', { }, }, + viewConfig: { + getRowClass: (record, _index) => record.get('enabled') ? '' : 'proxmox-disabled-row', + }, + columns: [ { header: gettext('Enabled'), width: 80, dataIndex: 'enabled', - xtype: 'checkcolumn', sortable: true, - disabled: true, - disabledCls: 'x-item-enabled', + align: 'center', stopSelection: false, + renderer: Proxmox.Utils.renderEnabledIcon, }, { text: gettext('Name'), -- 2.30.2