From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A1D6C9F91F for ; Fri, 9 Jun 2023 16:16:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8A6D32F4BF for ; Fri, 9 Jun 2023 16:16:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 9 Jun 2023 16:16:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DE2A042B0F for ; Fri, 9 Jun 2023 16:16:29 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 9 Jun 2023 16:16:25 +0200 Message-Id: <20230609141626.4766-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [element.io] Subject: [pve-devel] [PATCH widget-toolkit 1/2] apt repositories: fix typo for getting the default unknown text X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jun 2023 14:16:30 -0000 Could lead to a type error with classifyOrigin when there is a repository that doesn't have an InRelease file and cannot be detected as Debian/Proxmox origin from its URL. For me, it triggered with the element.io repository after changing to bookworm (which currently doesn't exist yet) and running apt update. Signed-off-by: Fiona Ebner --- Not too difficult to run into with external repos during upgrade preparation (when they are not yet bookworm-ready), so might also be worth it for the stable branch? src/node/APTRepositories.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js index cba9271..47c0a2c 100644 --- a/src/node/APTRepositories.js +++ b/src/node/APTRepositories.js @@ -697,7 +697,7 @@ Ext.define('Proxmox.node.APTRepositories', { repo.Path = file.path; repo.Index = n; if (infos[file.path] && infos[file.path][n]) { - repo.Origin = infos[file.path][n].origin || Proxmox.Utils.UnknownText; + repo.Origin = infos[file.path][n].origin || Proxmox.Utils.unknownText; repo.warnings = infos[file.path][n].warnings || []; if (repo.Enabled) { -- 2.39.2