From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AA6FB9D6B2 for ; Mon, 5 Jun 2023 01:37:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9306E21913 for ; Mon, 5 Jun 2023 01:37:24 +0200 (CEST) Received: from bastionodiso.odiso.net (bastionodiso.odiso.net [IPv6:2a0a:1580:2000::2d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 5 Jun 2023 01:37:22 +0200 (CEST) Received: from kvmformation3.odiso.net (formationkvm3.odiso.net [10.3.94.12]) by bastionodiso.odiso.net (Postfix) with ESMTP id C5A7B7B2A; Mon, 5 Jun 2023 01:37:14 +0200 (CEST) Received: by kvmformation3.odiso.net (Postfix, from userid 0) id AFB512C4D34; Mon, 5 Jun 2023 01:37:14 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Date: Mon, 5 Jun 2023 01:37:03 +0200 Message-Id: <20230604233709.1340089-1-aderumier@odiso.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.144 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy HEADER_FROM_DIFFERENT_DOMAINS 0.25 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH-SERIE pve-access-control/pve-manager/qemu-server] check permissions on local bridge X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Jun 2023 23:37:24 -0000 add vnet/localbridge permissions management Hi, as we has discuted some weeks ago, this patche serie introduce management of acl for vnets && local bridges I have reuse current sdn permissions path, to have common paths /sdn/vnets// where the local vmbr are in a virtual "localnetwork" zone /sdn/vnets/local/ Vlans permissions are also handled with /sdn/vnets/// if user have permissions on the zone, he have access to all vnets/vlan if user have permissions on the vnet/tag, he have access to only the specific vlan. if user have permissions on the vnet, he have access to all vlans of the vnet I have reworked the sdn zone panel from the tree, to manage permissions on displayed vnets. some screenshots: https://mutulin1.odiso.net/sdnzone-perm.png https://mutulin1.odiso.net/localzone-perm.png for proxmox7: (for users be able to add permissions before upgrade to pve8) pve-access-control: patch1 (to new /vnet/vlan path) pve-manager : patch1-2 for the new gui changelog v2: - use /vnets/vlan instead /vnets.vlan - rework the bridge filtering when user have access only to a specific vlan - api2 network: always check bridge access if no filter is defined todo: - add permissions on clone/restore ? pve-access-control: Alexandre Derumier (2): access control: add /sdn/vnets// path rpcenvironnment: add check_sdn_bridge src/PVE/AccessControl.pm | 1 + src/PVE/RPCEnvironment.pm | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) pve-manager: Alexandre Derumier (3): add vnet permissions panel add permissions management for "localnetwork" zone api2: network: check permissions for local bridges PVE/API2/Cluster.pm | 12 ++ PVE/API2/Network.pm | 26 ++- www/manager6/Makefile | 2 + www/manager6/sdn/Browser.js | 17 +- www/manager6/sdn/VnetACLView.js | 299 +++++++++++++++++++++++++++ www/manager6/sdn/ZoneContentPanel.js | 41 ++++ www/manager6/sdn/ZoneContentView.js | 52 ++++- 7 files changed, 420 insertions(+), 29 deletions(-) create mode 100644 www/manager6/sdn/VnetACLView.js create mode 100644 www/manager6/sdn/ZoneContentPanel.js qemu-server: Alexandre Derumier (1): api2: add check_bridge_access for create/update vm PVE/API2/Qemu.pm | 38 +++++++++++++++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-) -- 2.30.2