From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <a.lauterer@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D43F69CC5A for <pve-devel@lists.proxmox.com>; Thu, 1 Jun 2023 15:53:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BF13E1EDC0 for <pve-devel@lists.proxmox.com>; Thu, 1 Jun 2023 15:53:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Thu, 1 Jun 2023 15:53:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 583124826B for <pve-devel@lists.proxmox.com>; Thu, 1 Jun 2023 15:53:43 +0200 (CEST) From: Aaron Lauterer <a.lauterer@proxmox.com> To: pve-devel@lists.proxmox.com Date: Thu, 1 Jun 2023 15:53:35 +0200 Message-Id: <20230601135342.2903359-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.094 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v3 qemu-server, container, docs 0/7] migration: don't scan all storages, fail on aliases X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 01 Jun 2023 13:53:44 -0000 This patch series changes the behavior during guest migrations: Don't scan all storages for potential images belonging to the guest. Only migrate images referenced in the config. This made it necessary to handle pending changes explicitly which had been covered by the storage scan. We also added checks for any aliased volids and fail the migration if detected. The patches in qemu-server and pve-container are split int two. The first ones handle the change from scanning the storages to handle only referenced images. The second one adds the alias check. There is also a small patch for the documentation to add a hint that aliased storages should be avoided. changes since v2: - style fixes - qemu-server: mainly change the handling of pending changes - container: use NEW_DISK_RE to check if the volume is a not yet created pending volume More in each patch. qemu-server: Aaron Lauterer (4): migration: only migrate disks used by the guest tests: add migration test for pending disk migration: fail when aliased volume is detected tests: add migration alias check PVE/QemuMigrate.pm | 98 ++++++----------- PVE/QemuServer.pm | 9 +- test/MigrationTest/QemuMigrateMock.pm | 9 ++ test/run_qemu_migrate_tests.pl | 151 +++++++++++++++++++++++++- 4 files changed, 198 insertions(+), 69 deletions(-) container: Aaron Lauterer (2): migration: only migrate volumes used by the guest migration: fail when aliased volume is detected src/PVE/LXC/Migrate.pm | 51 +++++++++++++++++------------------------- 1 file changed, 21 insertions(+), 30 deletions(-) docs: Aaron Lauterer (1): storage: add hint to avoid storage aliasing pvesm.adoc | 3 +++ 1 file changed, 3 insertions(+) -- 2.30.2