From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E257E9CA14 for ; Thu, 1 Jun 2023 00:29:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BFDFBFC6E for ; Thu, 1 Jun 2023 00:29:09 +0200 (CEST) Received: from bastionodiso.odiso.net (bastionodiso.odiso.net [IPv6:2a0a:1580:2000::2d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 1 Jun 2023 00:29:06 +0200 (CEST) Received: from kvmformation3.odiso.net (formationkvm3.odiso.net [10.3.94.12]) by bastionodiso.odiso.net (Postfix) with ESMTP id 3A0CC8101; Thu, 1 Jun 2023 00:29:06 +0200 (CEST) Received: by kvmformation3.odiso.net (Postfix, from userid 0) id 279462D19B5; Thu, 1 Jun 2023 00:28:36 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Date: Thu, 1 Jun 2023 00:28:32 +0200 Message-Id: <20230531222834.1915972-1-aderumier@odiso.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.151 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy HEADER_FROM_DIFFERENT_DOMAINS 0.249 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH-SERIES pve-manager/qemu-server] fix#4689 autofind node with proxyto_callback X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2023 22:29:39 -0000 Hi, Currently, to manage qemu && lxc vms, we always need to specify nodename in uri. This is a problem with automation tools like terraform, where is node is registered in the state of terraform. (That mean, than if we move the vm on another node, terraform don't known it, and try to create the vm again or can't delete the vm,...) https://github.com/Telmate/terraform-provider-proxmox/issues/168 This can also be a potential problem with race, if we need to query /cluster/ressources to find the node, then another query on the vm. I have some discussion with fabian about it: https://bugzilla.proxmox.com/show_bug.cgi?id=4689 This patch series, find the nodename with proxyto_callback. a new api endpoint /guests/ is defined: /guests/(qemu|lxc)/vmid This patch series currently implement callback for api2::qemu I'm not sure how to create vm_create when vmid && nodename is not defined. Currently the callback return localhost, so the vm is created on the called node. todo (if this patch serie is ok for you): api2::qemu::agent (/guest/qemu/vmid/agent) api2::lxc (/guest/lxc/vmid) api2::lxc::config (/guest/lxc/vmid/config) api2::lxc::status (/guest/lxc/vmid/status) api2::lxc::snapshot (/guest/lxc/vmid/snapshot) api2::firewall:vm (/guest/(qemu|lxc)/vmid/firewall ) Alexandre Derumier (1): api2: add /guests path PVE/API2.pm | 6 +++++ PVE/API2/Guests.pm | 55 ++++++++++++++++++++++++++++++++++++++++++++++ PVE/API2/Makefile | 1 + 3 files changed, 62 insertions(+) create mode 100644 PVE/API2/Guests.pm Alexandre Derumier (1): api2: qemu: add proxyto_callback to find node if not defined PVE/API2/Qemu.pm | 157 ++++++++++++++++++++++++++++++++--------------- 1 file changed, 109 insertions(+), 48 deletions(-) -- 2.30.2