From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 780049C206 for ; Wed, 31 May 2023 10:13:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 51EAD36F24 for ; Wed, 31 May 2023 10:12:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 31 May 2023 10:12:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DA6AE47E2B for ; Wed, 31 May 2023 10:12:48 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 31 May 2023 10:12:46 +0200 Message-Id: <20230531081246.39012-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH ha-manager] api: fix/add return description for status endpoint X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2023 08:13:20 -0000 The fact that no 'items' was specified made the api-viewer throw a JavaScript exception: retinf.items is undefined Signed-off-by: Fiona Ebner --- src/PVE/API2/HA/Status.pm | 65 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 64 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/HA/Status.pm b/src/PVE/API2/HA/Status.pm index 201e17e..dc21049 100644 --- a/src/PVE/API2/HA/Status.pm +++ b/src/PVE/API2/HA/Status.pm @@ -71,7 +71,70 @@ __PACKAGE__->register_method ({ additionalProperties => 0, properties => {}, }, - returns => { type => 'array' }, + returns => { + type => 'array', + items => { + type => 'object', + properties => { + id => { + description => "Status entry ID (quorum, master, lrm:, service:).", + type => "string", + }, + node => { + description => "Node associated to status entry.", + type => "string", + }, + status => { + description => "Status of the entry (value depends on type).", + type => "string", + }, + type => { + description => "Type of status entry.", + enum => ["quorum", "master", "lrm", "service"], + }, + quorate => { + description => "For type 'quorum'. Whether the cluster is quorate or not.", + type => "boolean", + optional => 1, + }, + timestamp => { + description => "For type 'lrm','master'. Timestamp of the status information.", + type => "integer", + optional => 1, + }, + crm_state => { + description => "For type 'service'. Service state as seen by the CRM.", + type => "string", + optional => 1, + }, + max_relocate => { + description => "For type 'service'.", + type => "integer", + optional => 1, + }, + max_restart => { + description => "For type 'service'.", + type => "integer", + optional => 1, + }, + request_state => { + description => "For type 'service'. Requested service state.", + type => "string", + optional => 1, + }, + sid => { + description => "For type 'service'. Service ID.", + type => "string", + optional => 1, + }, + state => { + description => "For type 'service'. Verbose service state.", + type => "string", + optional => 1, + }, + }, + }, + }, code => sub { my ($param) = @_; -- 2.39.2