From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BFE549B207 for ; Wed, 24 May 2023 15:58:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0654C1F823 for ; Wed, 24 May 2023 15:57:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 24 May 2023 15:57:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4F1DA46E4E for ; Wed, 24 May 2023 15:57:34 +0200 (CEST) From: Lukas Wagner To: pve-devel@lists.proxmox.com Date: Wed, 24 May 2023 15:56:42 +0200 Message-Id: <20230524135649.934881-36-l.wagner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230524135649.934881-1-l.wagner@proxmox.com> References: <20230524135649.934881-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.157 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v2 pve-manager 35/42] ui: backup: allow to set notification-{channel, mode} for one-off backups X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 May 2023 13:58:05 -0000 Signed-off-by: Lukas Wagner --- www/manager6/window/Backup.js | 35 ++++++++++++++++++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js index 4b21c746..8c8cd7d8 100644 --- a/www/manager6/window/Backup.js +++ b/www/manager6/window/Backup.js @@ -30,12 +30,33 @@ Ext.define('PVE.window.Backup', { name: 'mode', }); + let notificationChannelSelector = Ext.create('PVE.form.NotificationChannelSelector', { + fieldLabel: gettext('Notification channel'), + name: 'notification-channel', + emptyText: Proxmox.Utils.noneText, + hidden: true, + }); + let mailtoField = Ext.create('Ext.form.field.Text', { fieldLabel: gettext('Send email to'), name: 'mailto', emptyText: Proxmox.Utils.noneText, }); + let notificationModeSelector = Ext.create('PVE.form.NotificationModeSelector', { + fieldLabel: gettext('Notify via'), + value: 'mail', + name: 'notification-mode', + listeners: { + change: function(f, v) { + let mailSelected = v === 'mail'; + notificationChannelSelector.setHidden(mailSelected); + mailtoField.setHidden(!mailSelected); + } + } + + }); + const keepNames = [ ['keep-last', gettext('Keep Last')], ['keep-hourly', gettext('Keep Hourly')], @@ -107,6 +128,12 @@ Ext.define('PVE.window.Backup', { success: function(response, opts) { const data = response.result.data; + if (!initialDefaults && data['notification-mode'] !== undefined) { + notificationModeSelector.setValue(data['notification-mode']); + } + if (!initialDefaults && data['notification-channel'] !== undefined) { + notificationChannelSelector.setValue(data['notification-channel']); + } if (!initialDefaults && data.mailto !== undefined) { mailtoField.setValue(data.mailto); } @@ -176,6 +203,8 @@ Ext.define('PVE.window.Backup', { ], column2: [ compressionSelector, + notificationModeSelector, + notificationChannelSelector, mailtoField, removeCheckbox, ], @@ -252,10 +281,14 @@ Ext.define('PVE.window.Backup', { remove: values.remove, }; - if (values.mailto) { + if (values.mailto && values['notification-mode'] === 'mail') { params.mailto = values.mailto; } + if (values['notification-channel'] && values['notification-mode'] === 'channel') { + params['notification-channel'] = values['notification-channel']; + } + if (values.compress) { params.compress = values.compress; } -- 2.30.2