From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E40F59A12B for ; Tue, 16 May 2023 16:51:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CDAFA1F0F3 for ; Tue, 16 May 2023 16:51:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 16 May 2023 16:51:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EBE6D45208 for ; Tue, 16 May 2023 16:51:19 +0200 (CEST) From: Noel Ullreich To: pve-devel@lists.proxmox.com Date: Tue, 16 May 2023 16:51:11 +0200 Message-Id: <20230516145115.103156-1-n.ullreich@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [cifsplugin.pm, glusterfsplugin.pm, nfsplugin.pm, cephfsplugin.pm, storage.pm, proxmox.com, dirplugin.pm, plugin.pm] Subject: [pve-devel] [PATCH pve-storage/pve-manager 0/3 v2] fix #623: show isos/vztmpl/snippets in subdirs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 May 2023 14:51:21 -0000 This patch fixes #623, allowing isos/vztmpl/snippets in subdirectories. This feature is opt-in and can be set from the API, web interface or with `pvesm`. I addressed the security concerns raised by Fabian, now parent directories in the path (i.e. `/my/path/../somewhere/`) are forbidded. I have kept the permission to use symlinks, however, if this is a security issue, symlinks can easily be forbidden as well. This, however, would be a breaking change. parts of the tests as well as the regex for checking, if a `/../` is in the path have been taken and/or adapted from an older patch that was never merged: https://lists.proxmox.com/pipermail/pve-devel/2020-May/043622.html This is a complete rework from v1, so I don't see a point in writing what the differences are. It's all different. Noel Ullreich (3): recursively go through subdirs to find files add `subdir-depth` option to filesystems update test for recursive subdir search PVE/Storage.pm | 7 ++++ PVE/Storage/CIFSPlugin.pm | 1 + PVE/Storage/CephFSPlugin.pm | 1 + PVE/Storage/DirPlugin.pm | 1 + PVE/Storage/GlusterfsPlugin.pm | 1 + PVE/Storage/NFSPlugin.pm | 1 + PVE/Storage/Plugin.pm | 61 +++++++++++++++++++----------- test/filesystem_path_test.pm | 18 +++++++++ test/list_volumes_test.pm | 68 ++++++++++++++++++++++++++++++++++ test/parse_volname_test.pm | 40 ++++++++++++++++++++ 10 files changed, 178 insertions(+), 21 deletions(-) Noel Ullreich (1): add field to set subdir-depth in web interface www/manager6/storage/Base.js | 11 +++++++++++ 1 file changed, 11 insertions(+) -- 2.30.2