From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <a.lauterer@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7EADF989D4 for <pve-devel@lists.proxmox.com>; Fri, 12 May 2023 14:41:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 623432DC7E for <pve-devel@lists.proxmox.com>; Fri, 12 May 2023 14:40:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Fri, 12 May 2023 14:40:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F232041F98 for <pve-devel@lists.proxmox.com>; Fri, 12 May 2023 14:40:43 +0200 (CEST) From: Aaron Lauterer <a.lauterer@proxmox.com> To: pve-devel@lists.proxmox.com Date: Fri, 12 May 2023 14:40:37 +0200 Message-Id: <20230512124043.888785-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.097 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [migrate.pm, qemumigratemock.pm, qemumigrate.pm] Subject: [pve-devel] [PATCH qemu-server, container v2 0/6] migration: don't scan all storages, fail on aliases X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 12 May 2023 12:41:15 -0000 v1 was the series: avoid migrating disk images multiple times We decided to take a different approach to avoid migrating potentially aliased disk images / volumes in a migration. Do not scan the storages for potential images belonging to the guest. Only migrate images referenced in the config. This made it necessary to add steps that used to be covered by the initial storage scan. Especially pending changes need to be handled explicitly. The patches are split in two parts for each repo, first remove the scan of all storages, secondly we check for aliases and fail. Due to the hard fail, this series is intended for Proxmox VE 8! More details in the patches themselves. qemu-server: Aaron Lauterer (4): migration: only migrate disks used by the guest tests: add migration test for pending disk migration: fail when aliased volume is detected tests: add migration alias check PVE/QemuMigrate.pm | 81 ++++++++-------- test/MigrationTest/QemuMigrateMock.pm | 10 ++ test/run_qemu_migrate_tests.pl | 132 ++++++++++++++++++++++++-- 3 files changed, 173 insertions(+), 50 deletions(-) container: Aaron Lauterer (2): migration: only migrate volumes used by the guest migration: fail when aliased volume is detected src/PVE/LXC/Migrate.pm | 56 ++++++++++++++++++++---------------------- 1 file changed, 26 insertions(+), 30 deletions(-) -- 2.30.2