From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C14599864B for ; Thu, 11 May 2023 11:46:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A3F001F366 for ; Thu, 11 May 2023 11:46:29 +0200 (CEST) Received: from maui.proxmox.com (unknown [94.136.29.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 11 May 2023 11:46:29 +0200 (CEST) Received: from maui.proxmox.com (localhost.localdomain [127.0.0.1]) by maui.proxmox.com (Proxmox) with ESMTP id E228B401BF7 for ; Thu, 11 May 2023 11:46:28 +0200 (CEST) Received: from maui.proxmox.com (localhost.localdomain [127.0.0.1]) by maui.proxmox.com (Proxmox) with ESMTP id 84C9B400DBD for ; Thu, 11 May 2023 11:46:28 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Thu, 11 May 2023 11:46:18 +0200 Message-Id: <20230511094620.667892-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.494 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager 0/2] ui: fw: allow selecting network interface for rules using combogrid X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 May 2023 09:46:29 -0000 For nodes, VMs and CTs we can show the user a list of available network interfaces (as that information is available) when creating a new firewall rule, much like it is already done in similar places. Adds a lot of convenience when creating new firewall rules if they are interface-specific, as you get a nice summary of the available ones and can simply select it instead of typing it out each time. The first patch refactors the `BridgeSelector` component a bit into a new `NetworkInterfaceSelector`, is essence allowing it be used for any type of network interfaces. No functional changes there. The second patch contains the actual implementation, using the `NetworkInterfaceSelector` from above for nodes and introducing a new component (which is mostly based of the former) for VMs/CTs. For datacenter rules, the simple textbox is kept. pve-manager: Christoph Heiss (2): ui: fw: generalize `BridgeSelector` into network interface selector ui: fw: allow selecting network interface for rules using combogrid www/manager6/Makefile | 3 +- www/manager6/form/BridgeSelector.js | 71 ----------------- www/manager6/form/NetworkInterfaceSelector.js | 79 +++++++++++++++++++ .../form/VMNetworkInterfaceSelector.js | 79 +++++++++++++++++++ www/manager6/grid/FirewallRules.js | 37 ++++++++- www/manager6/lxc/Config.js | 1 + www/manager6/lxc/Network.js | 3 +- www/manager6/qemu/Config.js | 1 + www/manager6/qemu/NetworkEdit.js | 3 +- 9 files changed, 199 insertions(+), 78 deletions(-) -- 2.39.2