From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3683499CA5 for ; Wed, 3 May 2023 15:38:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 18EF0B7BA for ; Wed, 3 May 2023 15:38:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 3 May 2023 15:38:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4A6E343110 for ; Wed, 3 May 2023 15:38:08 +0200 (CEST) From: Friedrich Weber To: pve-devel@lists.proxmox.com Date: Wed, 3 May 2023 15:37:23 +0200 Message-Id: <20230503133723.165739-1-f.weber@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.389 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, helpers.pm] Subject: [pve-devel] [PATCH qemu-server] vm start: set minimum timeout of 300s if using PCI passthrough X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 May 2023 13:38:40 -0000 The default VM startup timeout is max(30, VM memory in GiB) seconds. Multiple reports in the forum [0] [1] and the bug tracker [2] suggest this is too short when using PCI passthrough with a large amount of VM memory, since QEMU needs to map the whole memory during startup (see comment #2 in [2]). As a result, VM startup fails with "got timeout". To work around this, ensure that the startup timeout is at least 300s in case the VM config contains at least one `hostpci[n]` option. [0]: https://forum.proxmox.com/threads/83765/post-552071 [1]: https://forum.proxmox.com/threads/126398/post-552807 [2]: https://bugzilla.proxmox.com/show_bug.cgi?id=3502 Signed-off-by: Friedrich Weber --- Notes: An alternative workaround is offered by an unapplied patch series [3] of bug #3502 [2] that makes it possible to set VM-specific timeouts (also in the GUI). Users could use this option to manually set a higher timeout for VMs that use PCI passthrough. However, it is not immediately obvious that a higher timeout is necessary. Since the problem seems to come up somewhat frequently, I think it makes sense to have the heuristic choose a higher timeout by default. [2]: https://bugzilla.proxmox.com/show_bug.cgi?id=3502 [3]: https://lists.proxmox.com/pipermail/pve-devel/2023-January/055352.html PVE/QemuServer/Helpers.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm index e91f906..11897f4 100644 --- a/PVE/QemuServer/Helpers.pm +++ b/PVE/QemuServer/Helpers.pm @@ -160,6 +160,11 @@ sub config_aware_timeout { $timeout = 150; } + # Users reported the default timeout being too short when using PCI passthrough + if (grep(/^hostpci[0-9]+$/, keys %$config) && $timeout < 300) { + $timeout = 300; + } + return $timeout; } -- 2.30.2