From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4B3B9990F8 for ; Thu, 20 Apr 2023 14:32:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1F1612B55F for ; Thu, 20 Apr 2023 14:31:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 20 Apr 2023 14:31:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5CEC645D75 for ; Thu, 20 Apr 2023 14:31:45 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Thu, 20 Apr 2023 14:31:41 +0200 Message-Id: <20230420123141.1465161-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.087 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v2 manager] ui: utils: monitor_ceph_installed: avoid setting nodename to localhost X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2023 12:32:16 -0000 If a user is accessing the Ceph panel via Datacenter -> Ceph, then the install & config wizard might be shown. The nodename that is passed to the wizard will decide the ID of the initial MON and MGR services. Therefore, don't fall back to 'localhost' but the actual name of the node to which we are connected to. The result will be that the first MON and MGR will have the expected ID instead of 'localhost'. Signed-off-by: Aaron Lauterer --- changes since ui: CephInstallWizard: avoid using localhost on first configuration: * set the node name in the utils function that calls the wizard and not within the wizard. www/manager6/Utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 94e75d5c..d5dd2999 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -1722,7 +1722,7 @@ Ext.define('PVE.Utils', { rstore, /not (installed|initialized)/i, (_, error) => { - nodename = nodename || 'localhost'; + nodename = nodename || Proxmox.NodeName; let maskTarget = maskOwnerCt ? view.ownerCt : view; rstore.stopUpdate(); PVE.Utils.showCephInstallOrMask(maskTarget, error.statusText, nodename, win => { -- 2.30.2