From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4C9E69905A for ; Thu, 20 Apr 2023 10:06:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2FCCE288F1 for ; Thu, 20 Apr 2023 10:06:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 20 Apr 2023 10:06:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 66BBA45DBF for ; Thu, 20 Apr 2023 10:06:17 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 20 Apr 2023 10:06:16 +0200 Message-Id: <20230420080616.836255-3-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230420080616.836255-1-d.csapak@proxmox.com> References: <20230420080616.836255-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [RFC PATCH manager 3/3] ui: enable multiColumnSort for storage backup content X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2023 08:06:48 -0000 this enables the user to sort the grid by multiple columns simultaneously, e.g. by vmid and then by date Signed-off-by: Dominik Csapak --- sending as rfc because i'm not so sure about this. on one hand, this allows to recreate the original sorting if users want that, but the selection is a bit weird. there is no way to 'unsort' columns again, it simply uses the last 3 columns that were clicked especially with the last patch (statefulness) it becomes weird, but maybe we want this more than we want it to be stateful? www/manager6/storage/BackupView.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/storage/BackupView.js b/www/manager6/storage/BackupView.js index bb045f5b6..ebc476747 100644 --- a/www/manager6/storage/BackupView.js +++ b/www/manager6/storage/BackupView.js @@ -5,6 +5,7 @@ Ext.define('PVE.storage.BackupView', { showColumns: ['name', 'notes', 'protected', 'date', 'format', 'size'], + multiColumnSort: true, stateful: true, stateId: 'storage-backup-content', -- 2.30.2