From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0A71498F9C for ; Wed, 19 Apr 2023 17:44:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DF5212394C for ; Wed, 19 Apr 2023 17:43:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 19 Apr 2023 17:43:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 839FE45A5F for ; Wed, 19 Apr 2023 17:43:52 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Wed, 19 Apr 2023 17:43:48 +0200 Message-Id: <20230419154348.4099167-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager] ui: CephInstallWizard: avoid using localhost on first configuration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2023 15:44:24 -0000 If a user is accessing the Ceph install wizard via Datacenter -> Ceph and gets to the configuration part, the variable 'nodename' will be 'localhost'. This means, that the first MON and MGR would be using 'localhost' as their ID. Therefore fall back to 'Proxmox.NodeName' in that case to create the API POST request with the actual hostname, resulting in MON and MGR IDs as we would expect them. Signed-off-by: Aaron Lauterer --- www/manager6/ceph/CephInstallWizard.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/ceph/CephInstallWizard.js b/www/manager6/ceph/CephInstallWizard.js index 47efe182..0340e396 100644 --- a/www/manager6/ceph/CephInstallWizard.js +++ b/www/manager6/ceph/CephInstallWizard.js @@ -404,7 +404,7 @@ Ext.define('PVE.ceph.CephInstallWizard', { xtype: 'displayfield', fieldLabel: gettext('Monitor node'), cbind: { - value: '{nodename}', + value: get => get('nodename') === 'localhost' ? Proxmox.NodeName : get('nodename'), }, }, { @@ -461,7 +461,7 @@ Ext.define('PVE.ceph.CephInstallWizard', { var wizard = me.up('window'); var kv = wizard.getValues(); delete kv.delete; - var nodename = me.nodename; + let nodename = me.nodename === 'localhost' ? Proxmox.NodeName : me.nodename; delete kv.nodename; Proxmox.Utils.API2Request({ url: `/nodes/${nodename}/ceph/init`, -- 2.30.2