From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 600EC98C9F for ; Tue, 18 Apr 2023 11:32:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4307FC87A for ; Tue, 18 Apr 2023 11:31:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 18 Apr 2023 11:31:54 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 81F7545783 for ; Tue, 18 Apr 2023 11:31:54 +0200 (CEST) From: Leo Nunner To: pve-devel@lists.proxmox.com Date: Tue, 18 Apr 2023 11:31:43 +0200 Message-Id: <20230418093144.61317-2-l.nunner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230418093144.61317-1-l.nunner@proxmox.com> References: <20230418093144.61317-1-l.nunner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.141 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH container] api: network: get interfaces from containers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2023 09:32:25 -0000 Adds an 'interfaces' endpoint in the API (/nodes/{node}/lxc/{vmid}/interfaces'), which returns a list of interface names, together with a MAC, IPv4 and IPv6 address. This list may be expanded in the future. Note that this is only returned for *running* containers, stopped containers simply return an empty list. Signed-off-by: Leo Nunner --- src/PVE/API2/LXC.pm | 50 +++++++++++++++++++++++++++++++++++++++++++++ src/PVE/LXC.pm | 26 +++++++++++++++++++++++ 2 files changed, 76 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 50c9eaf..078d506 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -2495,6 +2495,56 @@ __PACKAGE__->register_method({ return PVE::GuestHelpers::config_with_pending_array($conf, $pending_delete_hash); }}); +__PACKAGE__->register_method({ + name => 'ip', + path => '{vmid}/interfaces', + method => 'GET', + protected => 1, + permissions => { + check => ['perm', '/vms/{vmid}', [ 'VM.Audit' ]], + }, + description => 'Get IP addresses of the specified container interface.', + parameters => { + additionalProperties => 0, + properties => { + node => get_standard_option('pve-node'), + vmid => get_standard_option('pve-vmid', { completion => \&PVE::LXC::complete_ctid }), + }, + }, + returns => { + type => "array", + items => { + type => 'object', + properties => { + name => { + type => 'string', + description => 'The name of the interface', + optional => 0, + }, + hwaddr => { + type => 'string', + description => 'The MAC address of the interface', + optional => 0, + }, + inet => { + type => 'string', + description => 'The IPv4 address of the interface', + optional => 1, + }, + inet6 => { + type => 'string', + description => 'The IPv6 address of the interface', + optional => 1, + }, + } + }, + }, + code => sub { + my ($param) = @_; + + return PVE::LXC::get_interfaces($param->{vmid}); + }}); + __PACKAGE__->register_method({ name => 'mtunnel', path => '{vmid}/mtunnel', diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index c4d53e8..bf57ede 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1034,6 +1034,32 @@ sub hotplug_net { PVE::LXC::Config->write_config($vmid, $conf); } +sub get_interfaces { + my ($vmid) = @_; + + my $pid = eval { find_lxc_pid($vmid); }; + return if $@; + + my $output; + # enters the network namespace of the container and executes 'ip a' + run_command(['nsenter', '-t', $pid, '--net', '--', 'ip', '--json', 'a'], + outfunc => sub { $output .= shift; }); + + my $config = JSON::decode_json($output); + + my $res; + foreach my $interface ($config->@*) { + my $obj = { name => $interface->{ifname} }; + foreach my $ip ($interface->{addr_info}->@*) { + $obj->{$ip->{family}} = $ip->{local} . "/" . $ip->{prefixlen}; + } + $obj->{hwaddr} = $interface->{address}; + push @$res, $obj + } + + return $res; +} + sub update_ipconfig { my ($vmid, $conf, $opt, $eth, $newnet, $rootdir) = @_; -- 2.30.2