From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9B2A1989D2 for ; Mon, 17 Apr 2023 09:09:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7208438809 for ; Mon, 17 Apr 2023 09:09:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 17 Apr 2023 09:09:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8A32B452C3 for ; Mon, 17 Apr 2023 09:09:17 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 17 Apr 2023 09:09:13 +0200 Message-Id: <20230417070914.13808-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager 1/2] ui: clone: validate name X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Apr 2023 07:09:48 -0000 As reported in the community forum[0], as opposed to VM/LXC creation, there is no validation for the name in the clone dialog. Use the same validation as the guest creation wizards do to catch errors early, before sending the API request. [0]: https://forum.proxmox.com/threads/125883/#post-549304 Signed-off-by: Fiona Ebner --- www/manager6/window/Clone.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/window/Clone.js b/www/manager6/window/Clone.js index e94cd92d..e4ea17ad 100644 --- a/www/manager6/window/Clone.js +++ b/www/manager6/window/Clone.js @@ -191,6 +191,7 @@ Ext.define('PVE.window.Clone', { { xtype: 'textfield', name: 'name', + vtype: 'DnsName', allowBlank: true, fieldLabel: me.guestType === 'lxc' ? gettext('Hostname') : gettext('Name'), }, -- 2.30.2