From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 03589984BB for ; Fri, 14 Apr 2023 14:39:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D3BD125DFE for ; Fri, 14 Apr 2023 14:38:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 14 Apr 2023 14:38:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B099D41EE3 for ; Fri, 14 Apr 2023 14:38:33 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 14 Apr 2023 14:38:26 +0200 Message-Id: <20230414123830.60720-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.052 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH-SERIES ha-manager] avoid rebalance-on-start for newly added already running service X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2023 12:39:05 -0000 As reported in the community forum[0], the current behavior when adding an already running service to HA is wrong. If rebalance selected a different node, the service would be stopped, offline migrated and started again. Since the rebalance-on-start is only intended to trigger on the stopped->start transition[1], this series makes sure the service is not migrated at all for rebalance-on-start if already running. [0]: https://forum.proxmox.com/threads/125597/ [1]: https://pve.proxmox.com/pve-docs/chapter-ha-manager.html#_crs_scheduling_points Fiona Ebner (4): sim: hardware: commands: fix documentation for add sim: hardware: commands: make it possible to add already running service tools: add IGNORED return code lrm: do not migrate if service already running upon rebalance on start src/PVE/HA/LRM.pm | 5 ++ src/PVE/HA/Manager.pm | 6 ++ src/PVE/HA/Sim/Hardware.pm | 16 +++-- src/PVE/HA/Tools.pm | 3 +- src/test/test-crs-static-rebalance2/README | 3 + src/test/test-crs-static-rebalance2/cmdlist | 9 +++ .../test-crs-static-rebalance2/datacenter.cfg | 7 +++ .../hardware_status | 5 ++ .../test-crs-static-rebalance2/log.expect | 63 +++++++++++++++++++ .../test-crs-static-rebalance2/manager_status | 1 + .../test-crs-static-rebalance2/service_config | 1 + .../static_service_stats | 1 + 12 files changed, 115 insertions(+), 5 deletions(-) create mode 100644 src/test/test-crs-static-rebalance2/README create mode 100644 src/test/test-crs-static-rebalance2/cmdlist create mode 100644 src/test/test-crs-static-rebalance2/datacenter.cfg create mode 100644 src/test/test-crs-static-rebalance2/hardware_status create mode 100644 src/test/test-crs-static-rebalance2/log.expect create mode 100644 src/test/test-crs-static-rebalance2/manager_status create mode 100644 src/test/test-crs-static-rebalance2/service_config create mode 100644 src/test/test-crs-static-rebalance2/static_service_stats -- 2.30.2