From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 371F991A8B for ; Mon, 3 Apr 2023 14:10:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1DB1E3FA50 for ; Mon, 3 Apr 2023 14:09:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 3 Apr 2023 14:09:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 339A5456CF for ; Mon, 3 Apr 2023 14:09:50 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 3 Apr 2023 14:09:42 +0200 Message-Id: <20230403120945.51924-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230403120945.51924-1-f.ebner@proxmox.com> References: <20230403120945.51924-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 1/4] cfg2cmd: use actual backend names instead of removed tty and paraport aliases X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Apr 2023 12:10:22 -0000 As described in: https://qemu-project.gitlab.io/qemu/about/removed-features.html#chardev-backend-aliases-tty-and-parport-removed-in-8-0 Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index c1d0fd2d..c7caa163 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -3794,7 +3794,7 @@ sub config_to_command { } } else { die "no such serial device\n" if ! -c $path; - push @$devices, '-chardev', "tty,id=serial$i,path=$path"; + push @$devices, '-chardev', "serial,id=serial$i,path=$path"; push @$devices, '-device', "isa-serial,chardev=serial$i"; } } @@ -3803,7 +3803,7 @@ sub config_to_command { for (my $i = 0; $i < $MAX_PARALLEL_PORTS; $i++) { if (my $path = $conf->{"parallel$i"}) { die "no such parallel device\n" if ! -c $path; - my $devtype = $path =~ m!^/dev/usb/lp! ? 'tty' : 'parport'; + my $devtype = $path =~ m!^/dev/usb/lp! ? 'serial' : 'parallel'; push @$devices, '-chardev', "$devtype,id=parallel$i,path=$path"; push @$devices, '-device', "isa-parallel,chardev=parallel$i"; } -- 2.30.2