From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9BDD190CD8 for ; Fri, 31 Mar 2023 12:05:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 805122675D for ; Fri, 31 Mar 2023 12:04:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 31 Mar 2023 12:04:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D754642E90 for ; Fri, 31 Mar 2023 12:04:54 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 31 Mar 2023 12:04:51 +0200 Message-Id: <20230331100451.1936833-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.010 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit] form: combo grid: use correct method to initialize the picker X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2023 10:05:25 -0000 'createPicker' does create the picker, but not all necessary initialization for the combobox (namely it does not set the owner field, but that's only an implementation detail). Instead 'getPicker' should be used for that, since that does all the necessary initialization and is the same function used when trying to open it. Without this patch, we leak the picker that was created with this call every time a combogrid is created. Signed-off-by: Dominik Csapak --- src/form/ComboGrid.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/form/ComboGrid.js b/src/form/ComboGrid.js index 29c3d26..55dee7e 100644 --- a/src/form/ComboGrid.js +++ b/src/form/ComboGrid.js @@ -408,7 +408,7 @@ Ext.define('Proxmox.form.ComboGrid', { // Create the picker at an early stage, so it is available to store the previous selection if (!me.picker) { - me.createPicker(); + me.getPicker(); } me.mon(me.store, 'beforeload', function() { -- 2.30.2