From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E9F9F90CB9 for ; Fri, 31 Mar 2023 12:03:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D3D18266FE for ; Fri, 31 Mar 2023 12:03:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 31 Mar 2023 12:03:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 814A342E33 for ; Fri, 31 Mar 2023 12:03:08 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 31 Mar 2023 12:03:08 +0200 Message-Id: <20230331100308.1922021-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.010 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] fix #4627: ui: backup edit: don't deselect all vms on load X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2023 10:03:40 -0000 'selectPoolMembers' will be called when the poolid field changes. (That can even happen when the mode is not even 'pool') Due to how the fields are set, there is a race condition that this will be called after the remaining fields were set up, including the vm list that might have entires selected. Since the first thing we do here is to deselect all, this wiped the vm selection sometimes. To fix it, check if we're actually in the correct mode before doing anything. Signed-off-by: Dominik Csapak --- www/manager6/dc/Backup.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index 7c6e244af..03a026513 100644 --- a/www/manager6/dc/Backup.js +++ b/www/manager6/dc/Backup.js @@ -96,6 +96,12 @@ Ext.define('PVE.dc.BackupEdit', { selectPoolMembers: function() { let me = this; + let mode = me.lookup('modeSelector').getValue(); + + if (mode !== 'pool') { + return; + } + let vmgrid = me.lookup('vmgrid'); let poolid = me.lookup('poolSelector').getValue(); -- 2.30.2