From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4FCBD915C3 for ; Mon, 27 Mar 2023 11:01:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2F9632E851 for ; Mon, 27 Mar 2023 11:01:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 27 Mar 2023 11:01:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D9DEE46F04 for ; Mon, 27 Mar 2023 11:01:09 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 27 Mar 2023 11:01:06 +0200 Message-Id: <20230327090106.15803-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230327090106.15803-1-f.ebner@proxmox.com> References: <20230327090106.15803-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.052 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 2/2] backup: prepare: improve error messages X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2023 09:01:41 -0000 Signed-off-by: Fiona Ebner --- PVE/VZDump/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index 036a7228..af197882 100644 --- a/PVE/VZDump/QemuServer.pm +++ b/PVE/VZDump/QemuServer.pm @@ -123,7 +123,7 @@ sub prepare { if ($storeid) { # The call in list context can be expensive for certain plugins like RBD, just get size $size = eval { PVE::Storage::volume_size_info($self->{storecfg}, $volid, 5) }; - die "no such volume '$volid'\n" if $@; + die "cannot determine size of volume '$volid' - $@\n" if $@; my $scfg = PVE::Storage::storage_config($self->{storecfg}, $storeid); $format = PVE::QemuServer::qemu_img_format($scfg, $volname); @@ -131,7 +131,7 @@ sub prepare { ($size, $format) = eval { PVE::Storage::volume_size_info($self->{storecfg}, $volid, 5); }; - die "no such volume '$volid'\n" if $@; + die "cannot determine size and format of volume '$volid' - $@\n" if $@; } my $diskinfo = { -- 2.30.2