From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C9A7892EA6 for ; Thu, 23 Mar 2023 16:27:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1CFBE2E810 for ; Thu, 23 Mar 2023 16:27:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 23 Mar 2023 16:27:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1101146606 for ; Thu, 23 Mar 2023 16:27:05 +0100 (CET) From: Stefan Sterz To: pve-devel@lists.proxmox.com Date: Thu, 23 Mar 2023 16:26:55 +0100 Message-Id: <20230323152656.1399307-5-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230323152656.1399307-1-s.sterz@proxmox.com> References: <20230323152656.1399307-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit 4/5] dark-mode: improve contrast ratios on the mask message X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2023 15:27:09 -0000 this removes the transparent background of the masks message box. this should help improve the contrast between the background and text. also sets an appropriate border color to make it stand out more. Signed-off-by: Stefan Sterz --- interestingly, sassc removes the alpha value from something like `rgba(38, 38, 38, 0.5)` but keeps it in this case. so `rgba($background-darker, 0.5)` works, but `rgba(38, 38, 38, 0.5)` does not. src/proxmox-dark/scss/extjs/_presentation.scss | 3 +-- src/proxmox-dark/scss/proxmox/_loadingindicator.scss | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/proxmox-dark/scss/extjs/_presentation.scss b/src/proxmox-dark/scss/extjs/_presentation.scss index 6be322a..6bf1ab5 100644 --- a/src/proxmox-dark/scss/extjs/_presentation.scss +++ b/src/proxmox-dark/scss/extjs/_presentation.scss @@ -1,8 +1,7 @@ // The mask that is applied when the window is unaccessible (Login // screen, Loading, ...) .x-mask { - background-color: $background-darker; - opacity: 0.5; + background-color: rgba($background-darker, 0.5); } // Shadows of floating windows like window modals, form selectors and diff --git a/src/proxmox-dark/scss/proxmox/_loadingindicator.scss b/src/proxmox-dark/scss/proxmox/_loadingindicator.scss index 5c320b3..3b58917 100644 --- a/src/proxmox-dark/scss/proxmox/_loadingindicator.scss +++ b/src/proxmox-dark/scss/proxmox/_loadingindicator.scss @@ -10,5 +10,5 @@ .x-mask-msg { background-color: $form-field-body-color; - border: solid 1px mix(black, $form-field-body-color, 25%); + border: solid 1px $border-color-alt; } -- 2.30.2