From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BFD9B92C09 for ; Thu, 23 Mar 2023 07:57:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A347B2E048 for ; Thu, 23 Mar 2023 07:57:55 +0100 (CET) Received: from bastionodiso.odiso.net (bastionodiso.odiso.net [IPv6:2a0a:1580:2000::2d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 23 Mar 2023 07:57:54 +0100 (CET) Received: from kvmformation3.odiso.net (formationkvm3.odiso.net [10.3.94.12]) by bastionodiso.odiso.net (Postfix) with ESMTP id C5CB480C3; Thu, 23 Mar 2023 07:57:53 +0100 (CET) Received: by kvmformation3.odiso.net (Postfix, from userid 0) id BBC582418E7; Thu, 23 Mar 2023 07:57:53 +0100 (CET) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Date: Thu, 23 Mar 2023 07:57:49 +0100 Message-Id: <20230323065750.17230-3-aderumier@odiso.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230323065750.17230-1-aderumier@odiso.com> References: <20230323065750.17230-1-aderumier@odiso.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% HEADER_FROM_DIFFERENT_DOMAINS 0.25 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.001 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] [PATCH qemu-server 1/1] qemu options: add tuning allocator X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2023 06:57:55 -0000 Add a new tuning option with allocator property. Available values: - Default is 'system', aka glibc malloc - tcmalloc (improve performance ceph librbd) Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 40be44d..761ab48 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -289,6 +289,19 @@ my $meta_info_fmt = { }, }; +my $tuning_fmt = { + allocator => { + type => 'string', + enum => [ qw(system tcmalloc) ], + default => 'system', + description => "Override the memory allocator used in QEMU via LD_PRELOAD.", + verbose_description => "Override the memory allocator used in QEMU via LD_PRELOAD." + ." Using tcmalloc might improve performance if ceph librbd is used." + ." NOTE: you must install the libtcmalloc-minimal4 package first!", + optional => 1, + }, +}; + my $confdesc = { onboot => { optional => 1, @@ -723,6 +736,12 @@ EODESCR description => "List of host cores used to execute guest processes, for example: 0,5,8-11", optional => 1, }, + tuning=> { + type => 'string', + format => $tuning_fmt, + description => "Tune some special features.", + optional => 1, + }, }; my $cicustom_fmt = { @@ -2192,6 +2211,16 @@ sub parse_rng { return $res; } +sub parse_tuning { + my ($value) = @_; + + return if !$value; + + my $res = eval { parse_property_string($tuning_fmt, $value) }; + warn $@ if $@; + return $res; +} + sub parse_meta_info { my ($value) = @_; @@ -5909,6 +5938,12 @@ sub vm_start_nolock { my $run_qemu = sub { PVE::Tools::run_fork sub { + + my $tuning = $conf->{tuning} ? parse_tuning($conf->{tuning}) : undef; + + $ENV{LD_PRELOAD} = "/usr/lib/x86_64-linux-gnu/libtcmalloc.so.4" + if $tuning && $tuning->{allocator} eq 'tcmalloc'; + PVE::Systemd::enter_systemd_scope($vmid, "Proxmox VE VM $vmid", %systemd_properties); my $tpmpid; -- 2.30.2