From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 15FD5926A2 for ; Tue, 21 Mar 2023 17:45:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F01221C3D9 for ; Tue, 21 Mar 2023 17:44:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 21 Mar 2023 17:44:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 652A845D7C for ; Tue, 21 Mar 2023 17:44:55 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 21 Mar 2023 17:44:51 +0100 Message-Id: <20230321164452.268358-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230321164452.268358-1-f.ebner@proxmox.com> References: <20230321164452.268358-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox-perl-rs 1/2] pve: test: resource scheduling: add test where memory is secondary to CPU X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2023 16:45:27 -0000 because memory usage differences are small. Signed-off-by: Fiona Ebner --- pve-rs/test/resource_scheduling.pl | 46 ++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/pve-rs/test/resource_scheduling.pl b/pve-rs/test/resource_scheduling.pl index fbedfe1..c6724a4 100755 --- a/pve-rs/test/resource_scheduling.pl +++ b/pve-rs/test/resource_scheduling.pl @@ -86,8 +86,54 @@ sub test_overcommitted { is($nodes[3], "A", 'fourth should be A'); } +sub test_balance_small_memory_difference_with_start_load { + my $static = PVE::RS::ResourceScheduling::Static->new(); + # Memory is different to avoid flaky results with what would otherwise be ties. + $static->add_node("A", 8, 10_000_000_000); + $static->add_node("B", 4, 9_000_000_000); + $static->add_node("C", 4, 8_000_000_000); + + $static->add_service_usage_to_node("A", { maxcpu => 4, maxmem => 1_000_000_000 }); + $static->add_service_usage_to_node("B", { maxcpu => 2, maxmem => 1_000_000_000 }); + $static->add_service_usage_to_node("C", { maxcpu => 2, maxmem => 1_000_000_000 }); + + my $service = { + maxcpu => 3, + maxmem => 16_000_000, + }; + + for (my $i = 0; $i < 20; $i++) { + my $score_list = $static->score_nodes_to_start_service($service); + + # imitate HA manager + my $scores = { map { $_->[0] => -$_->[1] } $score_list->@* }; + my @nodes = sort { + $scores->{$a} <=> $scores->{$b} || $a cmp $b + } keys $scores->%*; + + if ($i % 4 <= 1) { + is($nodes[0], "A", 'first should be A'); + is($nodes[1], "B", 'second should be B'); + is($nodes[2], "C", 'third should be C'); + } elsif ($i % 4 == 2) { + is($nodes[0], "B", 'first should be B'); + is($nodes[1], "C", 'second should be C'); + is($nodes[2], "A", 'third should be A'); + } elsif ($i % 4 == 3) { + is($nodes[0], "C", 'first should be C'); + is($nodes[1], "A", 'second should be A'); + is($nodes[2], "B", 'third should be B'); + } else { + die "internal error, got $i % 4 == " . ($i % 4) . "\n"; + } + + $static->add_service_usage_to_node($nodes[0], $service); + } +} + test_basic(); test_balance(); test_overcommitted(); +test_balance_small_memory_difference_with_start_load(); done_testing(); -- 2.30.2