From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8002992620 for ; Tue, 21 Mar 2023 14:27:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5837319B96 for ; Tue, 21 Mar 2023 14:27:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 21 Mar 2023 14:27:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7207B45D13 for ; Tue, 21 Mar 2023 14:27:12 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 21 Mar 2023 14:27:11 +0100 Message-Id: <20230321132711.3377257-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: fix duplicate references when using multiple DiskStorageSelectors X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2023 13:27:43 -0000 by removing the references and change the one place where we used one of the references. Signed-off-by: Dominik Csapak --- while i tested all places where we have a disk selector (wizard, clone, efidisk, add hd) i am not super sure i found all uses i grepped after the references, and only found one use where we used it in a lookup/lookupReference, but maybe someone else too can check that everything still works... www/manager6/form/DiskStorageSelector.js | 4 ---- www/manager6/window/Clone.js | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/www/manager6/form/DiskStorageSelector.js b/www/manager6/form/DiskStorageSelector.js index abd46debc..860a3b3ca 100644 --- a/www/manager6/form/DiskStorageSelector.js +++ b/www/manager6/form/DiskStorageSelector.js @@ -118,7 +118,6 @@ Ext.define('PVE.form.DiskStorageSelector', { xtype: 'pveStorageSelector', itemId: 'hdstorage', name: 'hdstorage', - reference: 'hdstorage', fieldLabel: me.storageLabel, nodename: me.nodename, storageContent: me.storageContent, @@ -136,7 +135,6 @@ Ext.define('PVE.form.DiskStorageSelector', { { xtype: 'pveFileSelector', name: 'hdimage', - reference: 'hdimage', itemId: 'hdimage', fieldLabel: gettext('Disk image'), nodename: me.nodename, @@ -146,7 +144,6 @@ Ext.define('PVE.form.DiskStorageSelector', { { xtype: 'numberfield', itemId: 'disksize', - reference: 'disksize', name: 'disksize', fieldLabel: gettext('Disk size') + ' (GiB)', hidden: me.hideSize, @@ -160,7 +157,6 @@ Ext.define('PVE.form.DiskStorageSelector', { { xtype: 'pveDiskFormatSelector', itemId: 'diskformat', - reference: 'diskformat', name: 'diskformat', fieldLabel: gettext('Format'), nodename: me.nodename, diff --git a/www/manager6/window/Clone.js b/www/manager6/window/Clone.js index e94cd92dc..cab2339a9 100644 --- a/www/manager6/window/Clone.js +++ b/www/manager6/window/Clone.js @@ -170,7 +170,7 @@ Ext.define('PVE.window.Clone', { onlineValidator: true, listeners: { change: function(f, value) { - me.lookupReference('hdstorage').setTargetNode(value); + me.lookup('diskselector').getComponent('hdstorage').setTargetNode(value); }, }, }); -- 2.30.2