From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 40F4092295 for ; Tue, 21 Mar 2023 10:16:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 21451DC57 for ; Tue, 21 Mar 2023 10:16:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 21 Mar 2023 10:16:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BD8B445B59 for ; Tue, 21 Mar 2023 10:16:10 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 21 Mar 2023 10:16:10 +0100 Message-Id: <20230321091610.1416089-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230321091610.1416089-1-d.csapak@proxmox.com> References: <20230321091610.1416089-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 2/2] ui: lvmthin: fix not being able to edit the storage X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2023 09:16:42 -0000 the change handler of the edit config from a displayeditfield still triggers, even if not shown/disabled. sadly this enabled another editconfig part of a displayeditfield, which triggers an error in the api to fix that, simply check if this field is disabled before setting the other fields value Signed-off-by: Dominik Csapak --- www/manager6/storage/LvmThinEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/storage/LvmThinEdit.js b/www/manager6/storage/LvmThinEdit.js index c3b55d87d..63f1fd78f 100644 --- a/www/manager6/storage/LvmThinEdit.js +++ b/www/manager6/storage/LvmThinEdit.js @@ -148,7 +148,7 @@ Ext.define('PVE.storage.LvmThinInputPanel', { }, change: function(f, value) { let vgField = this.up('inputpanel').lookup('thinPoolSelector'); - if (vgField) { + if (vgField && !f.isDisabled()) { vgField.setDisabled(!value); vgField.setVG(value); vgField.setValue(''); -- 2.30.2