From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D081C90A44 for ; Thu, 16 Mar 2023 14:48:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B800057F8 for ; Thu, 16 Mar 2023 14:48:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 16 Mar 2023 14:48:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 30C044416E for ; Thu, 16 Mar 2023 14:48:21 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Thu, 16 Mar 2023 14:48:15 +0100 Message-Id: <20230316134820.1193518-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.041 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 manager 0/5] rework ceph cfg api & fix 2515 use size defaults X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Mar 2023 13:48:22 -0000 The main goal of this series is to improve the handling of configured default size & min_size values when creating a new Ceph Pool in the GUI. But since that means a new necessary API endpoint, we also rework the Ceph API to make it cleaner. A new API endpoint is used: 'cfg' and the current 'config' and 'configdb' are moved there (first 2 patches). The result is * cfg/ * raw (formerly config) * db (formerly configdb) Then we add a new endpoint 'cfg/value' that allows us to fetch values for config keys that are set either in the config DB of Ceph or in the ceph.conf file. More in each patch. Depending on how we want to handle the API deprecation, we might just want to apply the first two patches with 7.4, even if the actual implementation of the fix itself will have to wait. changes since v1: * 2 new patches to rework API so that the new endpoint has its place * incorporated suggested code changes Aaron Lauterer (5): api: ceph: add ceph/cfg path, deprecate ceph/config and ceph/configdb ui: ceph config: use new ceph/cfg/ API endpoints api: ceph: add endpoint to fetch config keys fix #2515: ui: ceph pool create: use configured defaults for size and min_size ui: ceph pool edit: rework with controller and formulas PVE/API2/Ceph.pm | 15 ++- PVE/API2/Ceph/Cfg.pm | 197 ++++++++++++++++++++++++++++++++++++ PVE/API2/Ceph/Makefile | 1 + www/manager6/ceph/Config.js | 4 +- www/manager6/ceph/Pool.js | 144 +++++++++++++++++++------- 5 files changed, 321 insertions(+), 40 deletions(-) create mode 100644 PVE/API2/Ceph/Cfg.pm -- 2.30.2