From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DBA9C90676 for ; Thu, 16 Mar 2023 11:01:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BE71D2A3F for ; Thu, 16 Mar 2023 11:01:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 16 Mar 2023 11:01:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AB100426A2 for ; Thu, 16 Mar 2023 11:01:41 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Thu, 16 Mar 2023 11:01:36 +0100 Message-Id: <20230316100136.97432-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 installer] fix #4430: add UTC timezone as option to installer X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Mar 2023 10:01:42 -0000 Adds 'Etc/UTC' as option to the timezone selection, regardless of what country is selected. The 'Etc/' prefix needs to be stripped for the installation, as this value is written to /etc/timezone. PVE/PMG/PBS already use 'UTC' without the prefix, so avoid regressing them. Signed-off-by: Christoph Heiss --- Would it be sensible to fix up the timezone change component in the UI so that it uses 'Etc/UTC' (which is the canonical timezone name for UTC) as well? As separate patch in the future, of course. v1: https://lists.proxmox.com/pipermail/pve-devel/2023-March/056202.html proxinstall | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/proxinstall b/proxinstall index 79abc34..899b534 100755 --- a/proxinstall +++ b/proxinstall @@ -2658,6 +2658,7 @@ sub update_zonelist { $cb->signal_connect('changed' => sub { $timezone = $cb->get_active_text(); + $timezone =~ s|Etc/UTC|UTC|; }); my @za; @@ -2674,6 +2675,9 @@ sub update_zonelist { $i++; } + # Append Etc/UTC here, so it is always the last item and never the default for any country. + $cb->append_text('Etc/UTC'); + $cb->set_active($ind || 0); $cb->show; -- 2.39.2