From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 54CE790636 for ; Thu, 16 Mar 2023 10:17:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2DE8A1DA6 for ; Thu, 16 Mar 2023 10:17:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 16 Mar 2023 10:17:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4EDD942DEB for ; Thu, 16 Mar 2023 10:17:28 +0100 (CET) Date: Thu, 16 Mar 2023 10:17:27 +0100 From: Christoph Heiss To: Thomas Lamprecht Cc: Proxmox VE development discussion Message-ID: <20230316091727.xfcrhernupazgpkh@maui.proxmox.com> References: <20230315122635.286988-1-c.heiss@proxmox.com> <8ea5bbf5-127e-1a8c-15d2-e092b0ddea7d@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ea5bbf5-127e-1a8c-15d2-e092b0ddea7d@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer] fix #4430: add UTC timezone as option to installer X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Mar 2023 09:17:59 -0000 Thanks for the review! On Wed, Mar 15, 2023 at 02:23:09PM +0100, Thomas Lamprecht wrote: > [..] > > What I don't like as much that one has to set the country to the timezone, > which is confusing UX and will be subtle to most. > > Better ways might be: > > - add an explicit "Use UTC" checkbox that grey's out the country/timezone > selection then. Disadvantage here would be taking up extra space and expanding > the user input amount, which goes a bit against our "as simple as possible" > approach for the installer > > - Add UTC always to the time-zone selection, independent of what country is > selected. This keeps the selection where it belongs, and allows to quickly > change to UTC without any typing/searching required (at least for most countries) > > From a gut feeling I'd go for the second option, but didn't checked out how the > implementation would then look like. >From looking at the code while implementing this, the second option shouldn't be that much of a hassle to implement I'd say (and probably less than the first). Sounds like the better option to me too. The first option could also strike some users that this option is permament and cannot be changed after installation, due to the grey'ing out and such, I guess. I send a v2 soon with the second approach implemented, let's see how the look & feel of that is.