From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 91090927DE for ; Tue, 14 Mar 2023 16:08:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7A3F923351 for ; Tue, 14 Mar 2023 16:08:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 14 Mar 2023 16:08:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 80FA145E50 for ; Tue, 14 Mar 2023 16:08:44 +0100 (CET) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Tue, 14 Mar 2023 16:08:39 +0100 Message-Id: <20230314150839.248059-4-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230314150839.248059-1-m.carrara@proxmox.com> References: <20230314150839.248059-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v3 manager 3/3] ui: cert upload: fix private key field sending empty string X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Mar 2023 15:08:45 -0000 The private key's field is now excluded from the upload form's JSON data if it's left empty. Prior to this change, the form still used an empty string for the private key's field, even if no key was provided by the user. Because the key's field is marked as optional in the upload cert API endpoint, JSONSchema validation would therefore fail. Signed-off-by: Max Carrara --- www/manager6/node/Certificates.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/www/manager6/node/Certificates.js b/www/manager6/node/Certificates.js index 29c17359..a086581c 100644 --- a/www/manager6/node/Certificates.js +++ b/www/manager6/node/Certificates.js @@ -171,6 +171,9 @@ Ext.define('PVE.node.CertUpload', { onGetValues: function(values) { values.restart = 1; values.force = 1; + if (!values.key) { + delete values.key; + } return values; }, items: [ -- 2.39.2