From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EC94592182 for ; Mon, 13 Mar 2023 13:57:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CE152B566 for ; Mon, 13 Mar 2023 13:57:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 13 Mar 2023 13:57:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B0EE944732 for ; Mon, 13 Mar 2023 13:57:40 +0100 (CET) From: Friedrich Weber To: pve-devel@lists.proxmox.com Date: Mon, 13 Mar 2023 13:56:25 +0100 Message-Id: <20230313125625.1060320-1-f.weber@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.461 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server] fix: api: fix permission check for cloudinit drive update X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Mar 2023 12:57:42 -0000 Trying to regenerate a cloudinit drive as a non-root user via the API currently throws a Perl error, as reported in the forum [1]. This is due to a type mismatch in the permission check, where a string is passed but an array is expected. [1] https://forum.proxmox.com/threads/regenerate-cloudinit-by-put-api-return-500.124099/ Signed-off-by: Friedrich Weber --- To see if we have the same problem for other API endpoints, I ran: grep -r "['\"]perm['\"][^[]*]" . in my locally checked-out repos, but found only this single occurrence. PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 587bb22..0ea18eb 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1398,7 +1398,7 @@ __PACKAGE__->register_method({ proxyto => 'node', description => "Regenerate and change cloudinit config drive.", permissions => { - check => ['perm', '/vms/{vmid}', 'VM.Config.Cloudinit'], + check => ['perm', '/vms/{vmid}', ['VM.Config.Cloudinit']], }, parameters => { additionalProperties => 0, -- 2.30.2