From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AC2D091D0A for ; Sat, 11 Mar 2023 14:03:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8ABAD29DA5 for ; Sat, 11 Mar 2023 14:02:50 +0100 (CET) Received: from bastionodiso.odiso.net (bastionodiso.odiso.net [185.151.191.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Sat, 11 Mar 2023 14:02:49 +0100 (CET) Received: from kvmformation3.odiso.net (formationkvm3.odiso.net [10.3.94.12]) by bastionodiso.odiso.net (Postfix) with ESMTP id 6ABDB80B8; Sat, 11 Mar 2023 14:02:43 +0100 (CET) Received: by kvmformation3.odiso.net (Postfix, from userid 0) id 5685623B852; Sat, 11 Mar 2023 14:02:43 +0100 (CET) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Date: Sat, 11 Mar 2023 14:02:42 +0100 Message-Id: <20230311130242.2559893-1-aderumier@odiso.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% HEADER_FROM_DIFFERENT_DOMAINS 0.25 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.001 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH] fix #4585 : toolkit: configid type: add missing "-" character support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2023 13:03:20 -0000 JsonSchema is already ok: $CONFIGID_RE = qr/[a-z][a-z0-9_-]+/i; This is blocking creation of snapshot name with "-" in gui. (works fine command line) Signed-off-by: Alexandre Derumier --- src/Toolkit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Toolkit.js b/src/Toolkit.js index 2f4a01a..4314fb4 100644 --- a/src/Toolkit.js +++ b/src/Toolkit.js @@ -110,7 +110,7 @@ Ext.apply(Ext.form.field.VTypes, { gettext("Must end with") + ": 'A-Z', 'a-z', '0-9'
", ConfigId: function(v) { - return (/^[a-z][a-z0-9_]+$/i).test(v); + return (/^[a-z][a-z0-9_-]+$/i).test(v); }, ConfigIdText: gettext("Allowed characters") + ": 'A-Z', 'a-z', '0-9', '_'
" + gettext("Minimum characters") + ": 2
" + -- 2.30.2