From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C739A9123D for ; Fri, 10 Mar 2023 14:09:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B153F20EC2 for ; Fri, 10 Mar 2023 14:09:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 10 Mar 2023 14:09:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D08A646303 for ; Fri, 10 Mar 2023 14:09:15 +0100 (CET) From: Stefan Sterz To: pve-devel@lists.proxmox.com Date: Fri, 10 Mar 2023 14:08:37 +0100 Message-Id: <20230310130837.1188003-7-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230310130837.1188003-1-s.sterz@proxmox.com> References: <20230310130837.1188003-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 6/6] ui: make tree settings button like regular buttons X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2023 13:09:16 -0000 the "proxmox-inline-button" class is redundant in the crisp theme as it only sets the buttons text to black. we mainly use that class for "help" buttons. this is useful in the dark theme, because we want help buttons to stand out a bit so (possibly confused) users are drawn to them more easily. removing the class here doesn't change anything for "crisp", but makes the dark theme appear more consistent. also fixes up an unnecessary space. Signed-off-by: Stefan Sterz --- www/manager6/Workspace.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index 78ab37b6..8cee3638 100644 --- a/www/manager6/Workspace.js +++ b/www/manager6/Workspace.js @@ -469,8 +469,8 @@ Ext.define('PVE.StdWorkspace', { selview, { xtype: 'button', - cls: 'x-btn-default-toolbar-small proxmox-inline-button', - iconCls: 'fa fa-fw fa-gear x-btn-icon-el-default-toolbar-small ', + cls: 'x-btn-default-toolbar-small', + iconCls: 'fa fa-fw fa-gear x-btn-icon-el-default-toolbar-small', handler: () => { Ext.create('PVE.window.TreeSettingsEdit', { autoShow: true, -- 2.30.2