From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 34C35913EA for ; Fri, 10 Mar 2023 14:09:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 17EB820E4C for ; Fri, 10 Mar 2023 14:09:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 10 Mar 2023 14:09:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A7E5045640 for ; Fri, 10 Mar 2023 14:09:11 +0100 (CET) From: Stefan Sterz To: pve-devel@lists.proxmox.com Date: Fri, 10 Mar 2023 14:08:32 +0100 Message-Id: <20230310130837.1188003-2-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230310130837.1188003-1-s.sterz@proxmox.com> References: <20230310130837.1188003-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit 1/6] dark-theme: fix summary row background X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2023 13:09:43 -0000 previously an "!important" was missing from the `background-color` property. this meant that the background color wasn't properly overridden. the "!important" is necessary as it is also used in the light theme. Signed-off-by: Stefan Sterz --- src/proxmox-dark/scss/extjs/_grid.scss | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/proxmox-dark/scss/extjs/_grid.scss b/src/proxmox-dark/scss/extjs/_grid.scss index 77872b0..3719fdc 100644 --- a/src/proxmox-dark/scss/extjs/_grid.scss +++ b/src/proxmox-dark/scss/extjs/_grid.scss @@ -96,8 +96,10 @@ .x-grid-cell, .x-grid-rowwrap, .x-grid-cell-rowbody { + // the "!important" is needed here, because crisp also sets this + // as important + background-color: $background-darker !important; border-color: $border-color-alt; - background-color: $background-darker; } } -- 2.30.2