From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A7FD2909D8 for ; Thu, 9 Mar 2023 09:52:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8AD627BE1 for ; Thu, 9 Mar 2023 09:52:27 +0100 (CET) Received: from bastionodiso.odiso.net (bastionodiso.odiso.net [185.151.191.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 9 Mar 2023 09:52:26 +0100 (CET) Received: from kvmformation3.odiso.net (formationkvm3.odiso.net [10.3.94.12]) by bastionodiso.odiso.net (Postfix) with ESMTP id 042EB80CC; Thu, 9 Mar 2023 09:52:20 +0100 (CET) Received: by kvmformation3.odiso.net (Postfix, from userid 0) id 032A2133E39; Thu, 9 Mar 2023 09:52:20 +0100 (CET) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Date: Thu, 9 Mar 2023 09:52:15 +0100 Message-Id: <20230309085217.3649203-5-aderumier@odiso.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230309085217.3649203-1-aderumier@odiso.com> References: <20230309085217.3649203-1-aderumier@odiso.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.067 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% HEADER_FROM_DIFFERENT_DOMAINS 0.25 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.001 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH qemu-server 4/6] fix #4295 : virtio-(blk|scsi): enable multiqueue by default X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2023 08:52:57 -0000 set num_queues = maxcpus for qemu 8.0 redhat already done it in rhev since 2021 https://bugzilla.redhat.com/show_bug.cgi?id=1827722#c11 The -device virtio-blk,num-queues= and -device virtio-scsi,num_queues= parameters control how many virtqueues are available to the guest. Allocating one virtqueue per vCPU improves performance as follows: Interrupts are handled on the vCPU that submitted the request, avoiding IPIs The I/O scheduler is automatically set to “none” by the Linux block layer Signed-off-by: Alexandre Derumier --- PVE/QemuServer.pm | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index b49b59b..39d30e3 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -1505,7 +1505,14 @@ sub print_drivedevice_full { my $pciaddr = print_pci_addr("$drive_id", $bridges, $arch, $machine_type); $device = "virtio-blk-pci,drive=drive-$drive_id,id=${drive_id}${pciaddr}"; $device .= ",iothread=iothread-$drive_id" if $drive->{iothread}; + + my $machine_version = extract_version($machine_type, kvm_user_version()); + if (min_version($machine_version, 8, 0)) { + my ($sockets, $cores, $maxcpus) = get_cpu_topology($conf); + $drive->{queues} = $maxcpus if !$drive->{queues}; + } $device .= ",num-queues=$drive->{queues}" if $drive->{queues}; + } elsif ($drive->{interface} eq 'scsi') { my ($maxdev, $controller, $controller_prefix) = scsihw_infos($conf, $drive); @@ -4043,6 +4050,12 @@ sub config_to_command { ); } + if (min_version($machine_version, 8, 0)) { + my ($sockets, $cores, $maxcpus) = get_cpu_topology($conf); + $drive->{queues} = $maxcpus if !$drive->{queues}; + + } + my $queues = ''; if($conf->{scsihw} && $conf->{scsihw} eq "virtio-scsi-single" && $drive->{queues}){ $queues = ",num_queues=$drive->{queues}"; @@ -4306,6 +4319,12 @@ sub vm_deviceplug { $devicefull .= ",iothread=iothread-$deviceid"; } + my $machine_version = PVE::QemuServer::Machine::extract_version($machine_type); + if (min_version($machine_version, 8, 0)) { + my ($sockets, $cores, $maxcpus) = get_cpu_topology($conf); + $device->{queues} = $maxcpus if !$device->{queues}; + } + if($deviceid =~ m/^virtioscsi(\d+)$/ && $device->{queues}) { $devicefull .= ",num_queues=$device->{queues}"; } -- 2.30.2