From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 562D993F3; Wed, 8 Mar 2023 17:37:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3FB668FFA; Wed, 8 Mar 2023 17:37:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS; Wed, 8 Mar 2023 17:37:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A1154462E5; Wed, 8 Mar 2023 17:37:06 +0100 (CET) From: Stefan Sterz To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com Date: Wed, 8 Mar 2023 17:36:56 +0100 Message-Id: <20230308163658.2453420-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230308161840.2396113-1-s.sterz@proxmox.com> References: <20230308161840.2396113-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.097 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit v1 2/6] subscription/summary/backup: stop setting the background color X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2023 16:37:08 -0000 setting the background color in js code adds that property as a style attribute to the element. that makes it hard to alter later via css and makes it hard to dynamically change the color e.g., if we want to add different themes. the background color for these elements are white already anyway, so just remove them here. Signed-off-by: Stefan Sterz --- src/node/APT.js | 1 - src/window/AddTotp.js | 1 - src/window/DiskSmart.js | 1 - src/window/PackageVersions.js | 1 - 4 files changed, 4 deletions(-) diff --git a/src/node/APT.js b/src/node/APT.js index 2e5a776..739aaf3 100644 --- a/src/node/APT.js +++ b/src/node/APT.js @@ -116,7 +116,6 @@ Ext.define('Proxmox.node.APT', { let view = Ext.createWidget('component', { autoScroll: true, style: { - 'background-color': 'white', 'white-space': 'pre', 'font-family': 'monospace', padding: '5px', diff --git a/src/window/AddTotp.js b/src/window/AddTotp.js index bdb4826..080b361 100644 --- a/src/window/AddTotp.js +++ b/src/window/AddTotp.js @@ -224,7 +224,6 @@ Ext.define('Proxmox.window.AddTotp', { visible: '{!secretEmpty}', }, style: { - 'background-color': 'white', 'margin-left': 'auto', 'margin-right': 'auto', padding: '5px', diff --git a/src/window/DiskSmart.js b/src/window/DiskSmart.js index b538ea1..1cae512 100644 --- a/src/window/DiskSmart.js +++ b/src/window/DiskSmart.js @@ -74,7 +74,6 @@ Ext.define('Proxmox.window.DiskSmart', { autoScroll: true, padding: 5, style: { - 'background-color': 'white', 'white-space': 'pre', 'font-family': 'monospace', }, diff --git a/src/window/PackageVersions.js b/src/window/PackageVersions.js index e79d29f..aaa1372 100644 --- a/src/window/PackageVersions.js +++ b/src/window/PackageVersions.js @@ -45,7 +45,6 @@ Ext.define('Proxmox.window.PackageVersions', { html: '{packageList}', }, style: { - 'background-color': 'white', 'white-space': 'pre', 'font-family': 'monospace', }, -- 2.30.2