From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CF64D91D5 for ; Wed, 8 Mar 2023 13:09:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AB51A1FEDD for ; Wed, 8 Mar 2023 13:09:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 8 Mar 2023 13:09:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D184245E50 for ; Wed, 8 Mar 2023 13:09:19 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Wed, 8 Mar 2023 13:09:17 +0100 Message-Id: <20230308120919.1646218-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v3 manager 0/2] ui: ceph: improve discoverability of warning details X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2023 12:09:50 -0000 The goal for this small series is to make it easier/more obvious to see that there are potentially more details for a warning ceph is showing by: * having a tooltip with the details (limited in length) * making the detail/info button more visible changes since v2: * don't use arrow functions -> rework context in many places. mainly use 'this' now * destroy tooltip when no detail text is present. This can easily be tested by setting 'ceph osd set noout' for example * guard show/hide on info button with '?' v1: * change creation of info window to use autoShow * rework tooltip to: * only destroy it when leaving the whole grid, use show/hide for all other situations * factor out text handling of newlines and max lines * factor out updating and destroying into their own functions * add more listeners * hide it when hovering the info button * auto update it whenever the store is updated Aaron Lauterer (2): ui: ceph: make the warning detail button stand out more ui: ceph status: add tooltip with details to warnings www/manager6/ceph/Status.js | 129 ++++++++++++++++++++++++++++-------- 1 file changed, 103 insertions(+), 26 deletions(-) -- 2.30.2