From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E01FC9219 for ; Wed, 8 Mar 2023 12:47:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C189C1FD48 for ; Wed, 8 Mar 2023 12:47:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 8 Mar 2023 12:47:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E748C45DF0 for ; Wed, 8 Mar 2023 12:47:21 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com Date: Wed, 8 Mar 2023 12:47:09 +0100 Message-Id: <20230308114709.3391029-1-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.122 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pvesh.pm] Subject: [pve-devel] [PATCH manager] fix #4333: redirect API handler output to STDERR X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2023 11:47:22 -0000 otherwise, print/warn statements by the API endpoint are included in the output, which breaks JSON parsing in case of output-format == json*. Signed-off-by: Fabian Grünbichler --- Notes: technically a change that might require adapting some scripted calls, although we don't give any guarantees about pvesh output (or task log contents/stdout output of endpoints) I think ;) Suggested-by: reitermarkus (Proxmox Community Forum user) PVE/CLI/pvesh.pm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/pvesh.pm b/PVE/CLI/pvesh.pm index 9acf292a..31dce26d 100755 --- a/PVE/CLI/pvesh.pm +++ b/PVE/CLI/pvesh.pm @@ -309,7 +309,13 @@ sub call_api_method { $param->{$p} = $uri_param->{$p}; } - $data = $handler->handle($info, $param); + do { + # redirect stray output to STDERR + # only the returned $data should go to STDOUT + local *STDOUT; + open(STDOUT, '>&', STDERR); + $data = $handler->handle($info, $param); + }; } return if $opt_nooutput || $stdopts->{quiet}; -- 2.30.2