From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0184A8D60 for ; Tue, 7 Mar 2023 11:50:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CF439AE25 for ; Tue, 7 Mar 2023 11:50:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 7 Mar 2023 11:50:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0404342588 for ; Tue, 7 Mar 2023 11:50:23 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com Date: Tue, 7 Mar 2023 11:50:18 +0100 Message-Id: <20230307105018.3172827-1-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.124 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [certificate.pm] Subject: [pve-devel] [PATCH common] certificate: actually print openssl errors X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2023 10:50:54 -0000 print_errs (which is also called internally by die_now) will only 'warn' the collected error stack if the log level is set to tracing. otherwise, it will just return the error message(s) corresponding to the error stack as string. while they are not always the most user-friendly ones, they do provide additional context that might help to find out what is actually causing a particular failure. both helpers here actually provide a meaninful user friendly context (via $msg) as final line. Signed-off-by: Fabian Grünbichler --- Notes: noticed while testing Max' key check series src/PVE/Certificate.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/Certificate.pm b/src/PVE/Certificate.pm index 73091ff..3322557 100644 --- a/src/PVE/Certificate.pm +++ b/src/PVE/Certificate.pm @@ -181,12 +181,13 @@ sub der_to_pem { my $ssl_die = sub { my ($msg) = @_; + warn Net::SSLeay::print_errs(); Net::SSLeay::die_now($msg); }; my $ssl_warn = sub { my ($msg) = @_; - Net::SSLeay::print_errs(); + warn Net::SSLeay::print_errs(); warn $msg if $msg; }; -- 2.30.2