From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 51FA48A7E for ; Mon, 6 Mar 2023 15:23:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2EEC7258B for ; Mon, 6 Mar 2023 15:23:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 6 Mar 2023 15:23:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 471FF41CC4 for ; Mon, 6 Mar 2023 15:23:36 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 6 Mar 2023 15:23:31 +0100 Message-Id: <20230306142335.3858041-4-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230306142335.3858041-1-d.csapak@proxmox.com> References: <20230306142335.3858041-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 3/7] ui: VMSelector: change from filter to load parameters X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2023 14:23:37 -0000 so that we can modify the filters without having to consider filtering for the type. Note that 'vm' for the 'type' parameter also returns containers. Signed-off-by: Dominik Csapak --- www/manager6/form/VMSelector.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js index bb670f930..fb54e4835 100644 --- a/www/manager6/form/VMSelector.js +++ b/www/manager6/form/VMSelector.js @@ -15,12 +15,7 @@ Ext.define('PVE.form.VMSelector', { store: { model: 'PVEResources', - autoLoad: true, sorters: 'vmid', - filters: [{ - property: 'type', - value: /lxc|qemu/, - }], }, columnsDeclaration: [ @@ -189,6 +184,8 @@ Ext.define('PVE.form.VMSelector', { me.callParent(); + me.getStore().load({ params: { type: 'vm' } }); + if (me.nodename) { me.store.filters.add({ property: 'node', -- 2.30.2