From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7950B8B07 for ; Mon, 6 Mar 2023 15:24:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 57BD4258D for ; Mon, 6 Mar 2023 15:23:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 6 Mar 2023 15:23:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 51EFD45F5B for ; Mon, 6 Mar 2023 15:23:36 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 6 Mar 2023 15:23:30 +0100 Message-Id: <20230306142335.3858041-3-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230306142335.3858041-1-d.csapak@proxmox.com> References: <20230306142335.3858041-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 2/7] ui: VMSelector: improve {set, get}Value handling with a loading store X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2023 14:24:07 -0000 when we do {set,get}Value during a store load, the store might be empty or incomplete, so defer the selection after the load and cache the value for getValue invocations until the store is loaded Signed-off-by: Dominik Csapak --- www/manager6/form/VMSelector.js | 30 ++++++++++++++++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js index d80a21ec0..bb670f930 100644 --- a/www/manager6/form/VMSelector.js +++ b/www/manager6/form/VMSelector.js @@ -117,6 +117,9 @@ Ext.define('PVE.form.VMSelector', { getValue: function() { var me = this; + if (me.savedValue !== undefined) { + return me.savedValue; + } var sm = me.getSelectionModel(); var selection = sm.getSelection(); var values = []; @@ -130,6 +133,20 @@ Ext.define('PVE.form.VMSelector', { return values; }, + setValueSelection: function(value) { + let me = this; + + let store = me.getStore(); + let selection = value.map(item => store.findRecord('vmid', item, 0, false, true, true)).filter(r => r); + + let sm = me.getSelectionModel(); + if (selection.length) { + sm.select(selection); + } else { + sm.deselectAll(); + } + }, + setValue: function(value) { let me = this; if (!Ext.isArray(value)) { @@ -137,10 +154,15 @@ Ext.define('PVE.form.VMSelector', { } let store = me.getStore(); - let selection = value.map(item => store.findRecord('vmid', item, 0, false, true, true)).filter(r => r); - - me.getSelectionModel().select(selection); - + if (!store.isLoaded()) { + me.savedValue = value; + store.on('load', function() { + me.setValueSelection(value); + delete me.savedValue; + }, { single: true }); + } else { + me.setValueSelection(value); + } return me.mixins.field.setValue.call(me, value); }, -- 2.30.2