From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 186A285C6 for ; Fri, 3 Mar 2023 18:57:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EBB831A8A6 for ; Fri, 3 Mar 2023 18:57:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 3 Mar 2023 18:57:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B280D48DBB for ; Fri, 3 Mar 2023 18:57:11 +0100 (CET) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Fri, 3 Mar 2023 18:57:01 +0100 Message-Id: <20230303175705.214121-1-m.carrara@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH-SERIES v2 common/manager] Fix SSL Certificate and Key Upload Issues X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2023 17:57:43 -0000 This is v2 of https://lists.proxmox.com/pipermail/pve-devel/2023-February/055955.html Changes from v1: - properly handle OpenSSL errors[0] - provide actually correct format changes[1] - include trailing comma[2] - make JavaScript code a little more concise[3] [0] https://lists.proxmox.com/pipermail/pve-devel/2023-March/055962.html [1] https://lists.proxmox.com/pipermail/pve-devel/2023-March/055963.html [2] Not on mailing list unfortunately, boo! [3] https://lists.proxmox.com/pipermail/pve-devel/2023-March/055961.html pve-common: Max Carrara (2): certificate: add subroutine that checks if cert and key match certificate: fix formatting and whitespace src/PVE/Certificate.pm | 74 +++++++++++++++++++++++++++++++++--------- 1 file changed, 59 insertions(+), 15 deletions(-) pve-manager: Max Carrara (2): fix #4552: certhelpers: check if custom cert and key match on change ui: cert upload: fix private key field sending empty string PVE/CertHelpers.pm | 65 +++++++++++++++++++++++++++---- www/manager6/node/Certificates.js | 3 ++ 2 files changed, 60 insertions(+), 8 deletions(-) -- 2.30.2