From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F09CD8521 for ; Fri, 3 Mar 2023 16:59:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A6B9519BA4 for ; Fri, 3 Mar 2023 16:59:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 3 Mar 2023 16:59:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0A49346343 for ; Fri, 3 Mar 2023 16:59:26 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Fri, 3 Mar 2023 16:59:24 +0100 Message-Id: <20230303155925.1142116-2-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230303155925.1142116-1-a.lauterer@proxmox.com> References: <20230303155925.1142116-1-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 manager 1/2] ui: ceph: make the warning detail button stand out more X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2023 15:59:59 -0000 The button for more details is barely noticable as something one can click on. By making it more obvious that it is a button, users will hopefully notice it easier. Signed-off-by: Aaron Lauterer --- changes since v1: - use autoShow in the Ext.Create call www/manager6/ceph/Status.js | 56 +++++++++++++++++++------------------ 1 file changed, 29 insertions(+), 27 deletions(-) diff --git a/www/manager6/ceph/Status.js b/www/manager6/ceph/Status.js index bdcf3f1b..b223ab35 100644 --- a/www/manager6/ceph/Status.js +++ b/www/manager6/ceph/Status.js @@ -101,37 +101,39 @@ Ext.define('PVE.node.CephStatus', { flex: 1, }, { - xtype: 'actioncolumn', + xtype: 'widgetcolumn', width: 40, align: 'center', tooltip: gettext('Detail'), - items: [ - { - iconCls: 'x-fa fa-info-circle', - handler: function(grid, rowindex, colindex, item, e, record) { - var win = Ext.create('Ext.window.Window', { - title: gettext('Detail'), - resizable: true, - modal: true, - width: 650, - height: 400, - layout: { - type: 'fit', - }, - items: [{ - scrollable: true, - padding: 10, - xtype: 'box', - html: [ - '' + Ext.htmlEncode(record.data.summary) + '', - '
' + Ext.htmlEncode(record.data.detail) + '
', - ], - }], - }); - win.show(); - }, + widget: { + xtype: 'button', + baseCls: 'x-btn', + userCls: 'x-btn-default-toolbar-small', + iconCls: 'fa fa-fw fa-info-circle x-btn-icon-el-default-toolbar-small', + handler: function() { + let record = this.getWidgetRecord(); + Ext.create('Ext.window.Window', { + title: gettext('Detail'), + autoShow: true, + resizable: true, + modal: true, + width: 650, + height: 400, + layout: { + type: 'fit', + }, + items: [{ + scrollable: true, + padding: 10, + xtype: 'box', + html: [ + `${Ext.htmlEncode(record.data.summary)}`, + `
${Ext.htmlEncode(record.data.detail)}
`, + ], + }], + }); }, - ], + }, }, ], }, -- 2.30.2