From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B157895506 for ; Wed, 1 Mar 2023 13:54:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9B01319F37 for ; Wed, 1 Mar 2023 13:54:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 1 Mar 2023 13:54:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EF59F48D3F for ; Wed, 1 Mar 2023 13:54:51 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Wed, 1 Mar 2023 13:54:44 +0100 Message-Id: <20230301125444.552793-4-c.heiss@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230301125444.552793-1-c.heiss@proxmox.com> References: <20230301125444.552793-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.086 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] [PATCH qemu-server 3/3] net: Drop unused `firewall` argument to {add, del}_bridge_fdb() X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2023 12:54:53 -0000 PVE::Network::{add,del}_bridge_fdb() do not actually have a `firewall` parameter, so drop it. Same for the SDN equivalents. No functional changes. Signed-off-by: Christoph Heiss --- PVE/QemuServer.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 40be44d..9e5b0a0 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -8561,9 +8561,9 @@ sub add_nets_bridge_fdb { my $bridge = $net->{bridge}; if ($have_sdn) { - PVE::Network::SDN::Zones::add_bridge_fdb($iface, $mac, $bridge, $net->{firewall}); + PVE::Network::SDN::Zones::add_bridge_fdb($iface, $mac, $bridge); } elsif (-d "/sys/class/net/$bridge/bridge") { # avoid fdb management with OVS for now - PVE::Network::add_bridge_fdb($iface, $mac, $net->{firewall}); + PVE::Network::add_bridge_fdb($iface, $mac); } } } @@ -8580,9 +8580,9 @@ sub del_nets_bridge_fdb { my $bridge = $net->{bridge}; if ($have_sdn) { - PVE::Network::SDN::Zones::del_bridge_fdb($iface, $mac, $bridge, $net->{firewall}); + PVE::Network::SDN::Zones::del_bridge_fdb($iface, $mac, $bridge); } elsif (-d "/sys/class/net/$bridge/bridge") { # avoid fdb management with OVS for now - PVE::Network::del_bridge_fdb($iface, $mac, $net->{firewall}); + PVE::Network::del_bridge_fdb($iface, $mac); } } } -- 2.39.2