From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E2CAC95504 for ; Wed, 1 Mar 2023 13:54:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CE45A19F8D for ; Wed, 1 Mar 2023 13:54:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 1 Mar 2023 13:54:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DDD9548D44 for ; Wed, 1 Mar 2023 13:54:51 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Wed, 1 Mar 2023 13:54:43 +0100 Message-Id: <20230301125444.552793-3-c.heiss@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230301125444.552793-1-c.heiss@proxmox.com> References: <20230301125444.552793-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.087 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm] Subject: [pve-devel] [PATCH container 2/3] net: Drop unused `firewall` argument to add_bridge_fdb() X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2023 12:54:52 -0000 PVE::Network::SDN::Zones::add_bridge_fdb() does not actually have a `firewall` parameter, so drop it. No functional changes. Signed-off-by: Christoph Heiss --- src/PVE/LXC.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 54ee0d9..cd0aeb1 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -923,7 +923,7 @@ sub net_tap_plug : prototype($$$$$$;$) { if ($have_sdn) { PVE::Network::SDN::Zones::tap_plug($iface, $bridge, $tag, $firewall, $trunks, $rate); - PVE::Network::SDN::Zones::add_bridge_fdb($iface, $opts->{mac}, $bridge, $firewall) + PVE::Network::SDN::Zones::add_bridge_fdb($iface, $opts->{mac}, $bridge) if defined($opts->{mac}); } else { PVE::Network::tap_plug($iface, $bridge, $tag, $firewall, $trunks, $rate, $opts); -- 2.39.2