From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 72D9C95596 for ; Wed, 1 Mar 2023 13:55:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 59BBE19F57 for ; Wed, 1 Mar 2023 13:54:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 1 Mar 2023 13:54:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3B0FC48D3E for ; Wed, 1 Mar 2023 13:54:52 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Wed, 1 Mar 2023 13:54:41 +0100 Message-Id: <20230301125444.552793-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [zones.pm, qemuserver.pm, lxc.pm, proxmox.com] Subject: [pve-devel] [PATCH network/container/qemu-server 0/3] Drop unused `firewall` argument to {add, del}_bridge_fdb() X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2023 12:55:24 -0000 While working on this code, I noticed that ACAICS the `firewall` argument is never used (nor even declared!) [0] in both of PVE::Network::{add,del}_bridge_fdb(). Thus drop it everywhere and avoid needlessly passing around things which are never used anyway. Did some quick smoke-testing and everything kept working fine, but as there are really no functional changes, this should not effect anything. [0] https://git.proxmox.com/?p=pve-common.git;a=blob;f=src/PVE/Network.pm;h=355637b1;hb=HEAD#l299 pve-network: Christoph Heiss (1): zones: Drop unused `firewall` argument to {add,del}_bridge_fdb() PVE/Network/SDN/Zones.pm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) pve-container: Christoph Heiss (1): net: Drop unused `firewall` argument to add_bridge_fdb() src/PVE/LXC.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) qemu-server: Christoph Heiss (1): net: Drop unused `firewall` argument to {add,del}_bridge_fdb() PVE/QemuServer.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.39.2