From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 01A3494929 for ; Fri, 24 Feb 2023 13:10:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D740A95C7 for ; Fri, 24 Feb 2023 13:10:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 24 Feb 2023 13:10:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4788F483F4 for ; Fri, 24 Feb 2023 13:10:20 +0100 (CET) From: Matthias Heiserer To: pve-devel@lists.proxmox.com Date: Fri, 24 Feb 2023 13:10:07 +0100 Message-Id: <20230224121007.186614-1-m.heiserer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.218 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 widget-toolkit] ui: SMART: fix eslint error and show correct value X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2023 12:10:52 -0000 Signed-off-by: Matthias Heiserer --- Sorry for the long delay and the overall confusion! This is the v2 of https://lists.proxmox.com/pipermail/pve-devel/2023-February/055798.html The second arrow function spans multiple lines, that's because it really does not fit on a single one and previous attempts to reduce the size didn't work out. src/window/DiskSmart.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/window/DiskSmart.js b/src/window/DiskSmart.js index b538ea1..af2a023 100644 --- a/src/window/DiskSmart.js +++ b/src/window/DiskSmart.js @@ -159,12 +159,17 @@ Ext.define('Proxmox.window.DiskSmart', { { name: 'real-value', // FIXME remove with next major release (PBS 3.0) - calculate: data => (data.normalized ?? false) ? data.raw : data.value, + calculate: data => data.raw, }, { name: 'real-normalized', // FIXME remove with next major release (PBS 3.0) - calculate: data => data.normalized ?? data.raw, + calculate: data => { + if (data.normalized === undefined || data.raw === undefined) { + return data.value; + } + return data.normalized; + }, }, ], idProperty: 'name', -- 2.30.2