From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2FC3B946EC for ; Fri, 24 Feb 2023 08:37:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0DC006160 for ; Fri, 24 Feb 2023 08:37:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 24 Feb 2023 08:37:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3F78C48492 for ; Fri, 24 Feb 2023 08:37:46 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 24 Feb 2023 08:37:39 +0100 Message-Id: <20230224073739.5728-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server] clone: remove outdated TODO about bandwidth limit X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2023 07:37:47 -0000 Respecting bandwidth limit for offline clone was implemented by commit 56d16f16 ("fix #4249: make image clone or conversion respect bandwidth limit"). It's still not respected for EFI disks, but those are small, so just ignore it. Signed-off-by: Fiona Ebner --- Would've applied it directly, but am not 100% sure about the EFI disk - technically, we'd need to apply the limit there too, but seems not really worth the effort (qemu-img dd doesn't have the option) - so sending it for discussion. PVE/QemuServer.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index abb6221e..40be44db 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -8087,7 +8087,6 @@ sub clone_disk { qemu_drive_mirror($vmid, $src_drivename, $newvolid, $newvmid, $sparseinit, $jobs, $completion, $qga, $bwlimit); } else { - # TODO: handle bwlimits if ($dst_drivename eq 'efidisk0') { # the relevant data on the efidisk may be smaller than the source # e.g. on RBD/ZFS, so we use dd to copy only the amount -- 2.30.2