From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6D0CF9429D for ; Thu, 23 Feb 2023 11:14:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4ED492343D for ; Thu, 23 Feb 2023 11:14:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 23 Feb 2023 11:14:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 95C2F482E3 for ; Thu, 23 Feb 2023 11:14:45 +0100 (CET) From: Noel Ullreich To: pve-devel@lists.proxmox.com Date: Thu, 23 Feb 2023 11:14:41 +0100 Message-Id: <20230223101441.17619-1-n.ullreich@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.113 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox-widget-toolkit] Fix Unnecessarry parentheses error X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2023 10:14:46 -0000 As is, the code will throw an `ERR : line 162 col 22: no-extra-parens - Unnecessary parentheses around expression. (*)`. Since `data.normalized` will be evaluated as false if it is null anyway, adding a nullish operator `??` is not needed. Signed-off-by: Noel Ullreich --- src/window/DiskSmart.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/window/DiskSmart.js b/src/window/DiskSmart.js index b538ea1..834f065 100644 --- a/src/window/DiskSmart.js +++ b/src/window/DiskSmart.js @@ -159,7 +159,7 @@ Ext.define('Proxmox.window.DiskSmart', { { name: 'real-value', // FIXME remove with next major release (PBS 3.0) - calculate: data => (data.normalized ?? false) ? data.raw : data.value, + calculate: data => data.normalized ? data.raw : data.value, }, { name: 'real-normalized', -- 2.30.2